Josh Frankel

Results 12 comments of Josh Frankel

This may be common knowledge, but make sure you're also eager_loading your testing environment. I followed the above advice, but still had some accuracy issues until I discovered this. Just...

I'm unsure of why this is happening but it seems as though the mock user path expects the directory `/tmp/` but receives `/data/`. From looking through other PRs this seems...

Rebased with upstream Looks like that did the trick. Thanks @reedloden

Saving the alignment.py and then reloading ST fixes the problem. Thanks guys

> That said, all gems are installed inside a Linux docker container and might not be usable from outside docker Correct. I don't believe you'll have direct access to these...

Good point @kaste! Seems reasonable to assume it would. Can't remember why I didn't try that first 🤔

@steve21168 Thanks for digging into the spec failures and the update to the enterprise server api. There was a recently merged pull request here: https://github.com/joshmfrankel/simplecov-check-action/pull/20 which may fix your underlying...

@steve21168 Sure thing! Change this PR from updating the api url to just updating `alpine` => `slim` and we're good to go 👍🏻

@manuelmhtr has the approach I would take here. Gradual increase of the coverage threshold until you reach the desired amount. Changed files would be a great addition to the action....

Fantastic change. Looking at why CI failed currently, looks to be permission issue