simplecov-check-action icon indicating copy to clipboard operation
simplecov-check-action copied to clipboard

Allow setting the GitHub API URL from an environment variable

Open asonas opened this issue 2 years ago • 3 comments

Hi. I was unable to execute this action on GitHub Enterprise because the GitHub URL was hardcoded. To make this GitHub Action available from sources other than github.com, I will make changes to allow the URL to be modified via environment variables. Also, the hardcoded URL includes a path (/repos). In this method, I have made changes to only return the hostname and extract the path (/repos) to where it is being called.

asonas avatar Mar 23 '23 16:03 asonas

@joshmfrankel Could you review these changes?

asonas avatar Mar 29 '23 05:03 asonas

Fantastic change. Looking at why CI failed currently, looks to be permission issue

joshmfrankel avatar Apr 03 '23 15:04 joshmfrankel

I was able to finally come back around to this. Looks like there were several test failures due external http requests made in the test suite. Should be an easy fix though you may need to look into using ClimateControl for dealing with the EnvVar

rspec ./specs/integration/integration_spec.rb:46 # Check Action integration for coverage type line for Pushes Fails when coverage is lower than suite minimum
rspec ./specs/integration/integration_spec.rb:162 # Check Action integration for coverage type line for Pushes when SimpleCov-json coverage file is present Fails when coverage is lower than file minimum and prints failing files
rspec ./specs/integration/integration_spec.rb:200 # Check Action integration for coverage type line for Pushes when SimpleCov-json coverage file is present Fails when fallback suite minimum coverage fails
rspec ./specs/integration/integration_spec.rb:232 # Check Action integration for coverage type line for Pull Requests Fails when coverage is lower than minimum

joshmfrankel avatar Jun 06 '23 18:06 joshmfrankel

I believe that https://github.com/joshmfrankel/simplecov-check-action/pull/20 satisfied the request here on the failing tests. I'm going to close this one out. We could still use an update to the README.md

joshmfrankel avatar Dec 13 '24 14:12 joshmfrankel