simplecov-check-action icon indicating copy to clipboard operation
simplecov-check-action copied to clipboard

Published 20 hours ago • verified publisher icon joshmfrankel

Use api url from environment (fix for GHES), use debian image, fix specs

Open steve21168 opened this issue 1 year ago • 3 comments

Hi, this is a fix for using Github Enterprise Server API url. I've also updated the Dockerfile to use the slim image as opposed to alpine. My environment has DNS issues related to alpine images, this is a well documented issue that has to do with alpines use of musl C library.

I've also fixed the specs, whose failure was unrelated to this PR.

steve21168 avatar Jan 24 '24 20:01 steve21168

@steve21168 Thanks for digging into the spec failures and the update to the enterprise server api. There was a recently merged pull request here: https://github.com/joshmfrankel/simplecov-check-action/pull/20 which may fix your underlying issue.

joshmfrankel avatar May 29 '24 12:05 joshmfrankel

@joshmfrankel Hi thanks for the response. This should fix the GH api url issue. Unfortunately I still suffer from the alpine image issue. Just tested and I get an error message:

/usr/local/lib/ruby/3.1.0/socket.rb:227:in `getaddrinfo': Failed to open TCP connection ...

This is somewhat specific to my environment but I doubt I am the only one. Would you consider a PR just changing to the slim image?

steve21168 avatar May 29 '24 14:05 steve21168

@steve21168 Sure thing! Change this PR from updating the api url to just updating alpine => slim and we're good to go 👍🏻

joshmfrankel avatar Dec 13 '24 15:12 joshmfrankel