Josh McKinney

Results 1044 comments of Josh McKinney

I'd like to get buy-in / thoughts from the other maintainers before implementing this. I've removed the good first issue label for now.

@codex take a look through the existing places where we might expect users to want to add new Apps or widget libraries to the showcase and update some instructions. Do...

Looks like codex failed on setting up the environment on this one - oddly succeeds when doing the steps manual, but fails when doing it automatically while trying to run...

I've been out of town a few days and just getting back to things. I want to look at this more deeply, but I want to caution that I'm starting...

> Or rather I don't understand what is meant by The quote is in the context of a world where we're filtering, not in the context of a world where...

> Ohhh, ok in the context of splitting that does make sense. But what's the context for splitting lol? The rationale for that PR was that it aligned with existing...

I think you've raised some compelling arguments about keeping the newlines in the Line / Span rather than filtering them. I like where you're going with this, and I'm not...

> Maybe? I feel like the public APIs could remain largely the same, but the internals need to be rewritten with the notion of "incremental rendering." I think most performance...

Marking as draft for now - will come back to likely for 0.30

I'm going to keep comments in the origin PR just to keep them together.