Josh McKinney
Josh McKinney
@EdJoPaTo see my email about nits etc.
> As a crossterm version change is included with the upcoming release I would like to reduce the stuff needed from crossterm even further with the 0.28 release. Can we...
Something to consider as a total simplification would be to just have `Terminal::init()` and `Terminal::restore()` do the right thing (crossterm, stdout, raw mode, alternate screen). -> https://github.com/ratatui-org/ratatui/pull/1289
Closed by #1289
> I think we could do `render_ref_with_state()` instead, but I'm fine with `render_stateful_ref()`. Maybe check in with other maintainers before merging? I thought about that a little prior to writing...
> I have a preference for renaming these new trait names (the ones that are unstable) to `Render` and `RenderWithState` and then changing the names of the trait methods to...
> Let's move this point to a discussion on the forum. https://forum.ratatui.rs/t/naming-render-traits-methods/68 @kdheepak based on the logic in the above forum post are you happy to see this merged as...
> Probably off-topic to this PR… why move this to a different place? Personally the forum feels like a place for "how to do this" and "showoffs". Stuff that should...
Can you please test against the 0.30.0-beta to see if this is fixed there? I know we've made some changes to the Rect, Size and related code recently that may...
> Similar to the other PR, I think we could do `render_with_state()` instead, but I'm fine with `render_stateful()`. Again, worth checking in with other maintainers for a second opinion. likewise...