Josh McKinney

Results 1049 comments of Josh McKinney

In https://github.com/eyre-rs/eyre/pull/183#issuecomment-2241839595 I wrote: --- It turns out that my mental model for how the eyre_hook worked was a bit wrong (as noted in https://github.com/ratatui-org/ratatui/issues/1277). I thought it acted similarly...

Just a pure guess. Your code is reading from two threads. Don't do that if so. If the cli is multi-threaded, make sure that the read thread and the write...

Does your code have anything which could be reading events during the call to read_position (where the error message you're seeing originates): https://github.com/crossterm-rs/crossterm/blob/e104a7cb400910609cdde36f322e3905c4baa805/src/cursor/sys/unix.rs#L32-L56 In case the source code is not...

I wonder if there's any sort of standard for the timeout that would inform the right decision. (I'm not sure what an answer to this might look like though) I...

> At this point, I'm happy to accept a PR reverting the whole thing. Providing a slightly more accurate trace isn't worth panics. I think this would be the right...

I suggest discussion continue at https://github.com/hyperium/hyper/issues/3870

Anything that is doc specific. E.g.: the following mismatched code fence: ````rust //! ``` //! `` ```` Or a link to a non-existent item: ```rust /// [`foo`] ``` https://doc.rust-lang.org/rustdoc/lints.html has...

Seems reasonable to me.

We're discussing some issues with the List implementation currently in another issue (https://github.com/ratatui/ratatui/issues/1514). It would be worth making sure that is resolved before staring on this.