Josh McKinney

Results 1031 comments of Josh McKinney

Holding for resolution of discussion at https://forum.ratatui.rs/t/naming-render-traits-methods/68

Current: ![image](https://github.com/user-attachments/assets/cbb5e534-9548-4e6d-abdf-5752e1ec2440) New: ![ratatui-logo](https://github.com/user-attachments/assets/392c85dc-3ca0-4530-98a2-338a376408a7)

It can even be a little smaller... ![image](https://github.com/user-attachments/assets/d9fcf171-2707-4d69-aaf0-9ca7b6db098e)

BTW, in that change I also fixed the font kerning around the A / T to look a bit nicer. Altogether: Current: ![image](https://github.com/user-attachments/assets/cbb5e534-9548-4e6d-abdf-5752e1ec2440) First update ![ratatui-logo](https://github.com/user-attachments/assets/392c85dc-3ca0-4530-98a2-338a376408a7) Font Kerning fixed: ![ratatui-logo](https://github.com/user-attachments/assets/31528c32-94cc-4fb0-a8c6-467cad3dbda0)...

> > First update > > Font Kerning fixed: > > Hmm, the first one looks better to me. Second one's T has a space in it. I'm not sure...

Tweaked this a bit to add docs, tests, neater code, etc. Rendered docs: ![image](https://github.com/user-attachments/assets/17d3be3d-8397-4608-b711-29aa70a7b402)

Discussion moved to https://github.com/eyre-rs/eyre/issues/184

Some questions to think about: - should this be able to attach a callback for each hook type (panic / error)? - should this be another method similar to the...

It turns out that my mental model for how the eyre_hook worked was a bit wrong (as noted in https://github.com/ratatui-org/ratatui/issues/1277). I thought it acted similarly to the panic hook (catch...