Josh McKinney
Josh McKinney
Given that using RUSTC_BOOTSTRAP will clobber other builds that don't use it, would it make sense to automatically set a target-dir on all places where RUSTC_BOOTSTRAP is in use to...
Yep, For the benefit of the OP here, we delisted those pages because we had some problems with the approach suggested and we haven't made time to rewrite them. @kdheepak...
> I don't really know docker and so cannot review this PR. No problem - you were auto tagged because I previously added you to the maintainers config on the...
> I've implemented a workaround using crossterm directly, but it might be a worthwhile addition to this PR to have this be a supported directly. I don't think it would...
> I addressed all of @joshka 's comments, I think. Please let me know what's next. > > I'm not sure why the test `backend::test::tests::buffer_view_with_overwrites` is failing in CI. I...
I don't have permission to edit the PR, but here's the patch to fix this: ```patch diff --git a/Cargo.toml b/Cargo.toml index 4a8bdac9c..7e4597202 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -38,7 +38,7...
Ok, then we're just working out release timing on this one. I'm not sure whether the next release will be 0.28.2 (without this) or 0.29.0 (with this).
In theory you should be able to, but in practice I think this fits in a weird area whether the WidgetRef stuff causes some pain. BigText doesn't implement widget ref,...
@jfrader I'm consolidating several repos (popup, prompt, scrollview, etc.) into this one to make it simpler to maintain and do things like this that involve cross crate changes.
> @matchai In general the changes LGTM. The main issue I see with the general approach in the PR is that independent styling of vcs segments is no longer possible...