Josh Goebel

Results 1720 comments of Josh Goebel

Unflagged as good first issue, I have a feeling this one might be sneaky since it's going to be contextual in some grammars I think.

On review I'm not 100% sure we should highlight this as a number. Here is VS Code: The advantage being that is we don't style from/to that we have consistency....

So perhaps `tag` for from and to and number for `%`? I think if we color number we probably should color from/to and if we don't color from/to we probably...

We'll see if @allejo has any thoughts. I been working on the CSS consistency more and this is pretty simple once you flatten the grammar... you can just use from/to...

What kind of selector? :-) ``` selector-tag selector-id selector-class selector-attr selector-pseudo ``` LOL. What I showed above was `selector-tag`, which I feel like if we were just going to pick...

@allejo I looked into this more. I'm not sure that doing either of what you'd prefer (and what might be actually be best) is even possible. We have to handle...

> .1 is highlighted as a hljs-selector-class. @barhatsor Can you test master? I can't confirm this bug you've reported (at least not with CSS): Less and SCSS both seem problematic...

Oh? `css_consistency` was rebased and merged.... _master includes it now._ @allejo Did you ever really explain why highlighting the percent as a # and the other different is bad to...

Of course Stylus allows things like: ``` $green_dark = darken( $green, 10) $size = 10px ``` So now we'd need special rules in Stylus for: - `func(` (recursive) - variable...

> I find it problematic that the Default theme does not meet WCAG AA. This seems like a valid criticism. I don't think we can _majorly_ change our default theme...