Josh Goebel

Results 1704 comments of Josh Goebel

@not-my-profile Have you visited the https://prismjs.com project yet? If you have an issue open over there (or on any other code highlighters) I'd love a link. In some quick playing...

> I wrote a small Python script to check how Pygments styles fare when judged according to the WCAG contrast standard. Was this not possible with our CSS because of...

Ok here is what I whipped up really fast on top of our existing theme checker: #3394 ![Screen Shot 2021-11-05 at 6 06 53 AM](https://user-images.githubusercontent.com/6473/140494172-7c6d09c0-ee30-430c-b21b-c4d8c5aba9b2.png) It's not perfect (ie, dealing...

@Hirse You've played with the Demo stuff a bit I think... any thoughts on UI for this? We need a segmented list or toggle or filter or something... Is it...

> I don't think you should display a 🚫 for each stye that doesn't meet AA. Agreed, this isn't a public shaming. > There are certain service sectors where websites...

I'm not sure I have time to push this to the home plate fully right now but I'll try to finish up the "rough shape" of things and then update...

A beginning. Themes in the Demo now have badges. I updated my PR. ![Screen Shot 2021-11-06 at 9 33 27 AM](https://user-images.githubusercontent.com/6473/140611585-3356d29d-0236-485d-b657-f3ec914f1935.png)

@Hirse The whole A `display:block` will have to be revisited though. :-) Let me know if you might be interested in doing the front-end UI work on this (filtering, etc)....

Actually labeling every theme light or dark (right beside it) might be a bit much be we could decide to hide some badges and still use them for filtering... since...

I feel like that only works if they are collapsible or we have some sort of table of contents. Or maybe I'm just imagining what the UI would look like....