runtime icon indicating copy to clipboard operation
runtime copied to clipboard

Make public surface area of different CoreLibs consistent

Open akoeplinger opened this issue 3 years ago • 10 comments
trafficstars

In https://github.com/dotnet/runtime/pull/72143 we're adding a reference assembly for System.Private.CoreLib but right now the three different implementations (mono, coreclr and nativeaot) don't have consistent public API.

akoeplinger avatar Jul 21 '22 11:07 akoeplinger

Tagging subscribers to this area: @dotnet/area-meta See info in area-owners.md if you want to be subscribed.

Issue Details

In https://github.com/dotnet/runtime/pull/72143 we're adding a reference assembly for System.Private.CoreLib but right now the three different implementations (mono, coreclr and nativeaot) don't have consistent public API.

Author: akoeplinger
Assignees: -
Labels:

area-Meta

Milestone: -

ghost avatar Jul 21 '22 11:07 ghost

Tagging subscribers to this area: @dotnet/runtime-infrastructure See info in area-owners.md if you want to be subscribed.

Issue Details

In https://github.com/dotnet/runtime/pull/72143 we're adding a reference assembly for System.Private.CoreLib but right now the three different implementations (mono, coreclr and nativeaot) don't have consistent public API.

Author: akoeplinger
Assignees: -
Labels:

area-Infrastructure, untriaged

Milestone: -

ghost avatar Jul 21 '22 15:07 ghost

I wonder how much of a goal it is to make them all exactly consistent, or just all support an intersection of API? cc @jkotas @stephentoub @ViktorHofer

ericstj avatar Jul 21 '22 15:07 ericstj

Intersection is good enough. I do not think they need to be exactly consistent. There are good reasons for runtime-specific public surface, one example are runtime-specific hosting APIs.

jkotas avatar Jul 21 '22 15:07 jkotas

In that case I'm not sure what this would be tracking since I would expect that to be achieved by creating the contract and committing any baselines.

ericstj avatar Jul 21 '22 15:07 ericstj

This issue has been marked needs-author-action and may be missing some important information.

ghost avatar Aug 16 '22 00:08 ghost

@akoeplinger can you clarify what you think should happen, or close this if you agree with what's said here?

ericstj avatar Aug 16 '22 00:08 ericstj

This issue has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost avatar Aug 30 '22 03:08 ghost

I think @akoeplinger had in mind resolving warnings like these

MembersMustExist : Member 'protected System.String System.String System.Resources.ResourceManager.BaseNameField' does not exist in the reference but it does exist in the implementation.

or

MembersMustExist : Member 'public void System.AppContext.add_ProcessExit(System.EventHandler)' does not exist in the reference but it does exist in the implementation.

marek-safar avatar Sep 06 '22 11:09 marek-safar

This issue has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

ghost avatar Sep 20 '22 15:09 ghost

I think this is mostly done

agocke avatar Aug 15 '23 23:08 agocke