roryqi comments

Results 407 comments of


                                            roryqi

[#1149] fix: GC logs in JDK 11 do not include date and time stamps.

@zhengchenyu Could you help review this pr?

[Improvement] Operator should support K8S 1.24

@advancedxy @wangao1236 Could you give me some input?

[Improvement] Operator should support K8S 1.24

I have a solution. https://github.com/VictoriaMetrics/operator/blob/master/controllers/factory/k8stools/version.go

[Improvement] Operator should support K8S 1.24

@zhengchenyu @qijiale76 Could you have any ideas?

[#1673] fix(K8S): Fix the deployment of stable version K8S cluster

I verified this patch in the AWS EKS 1.28. It's ok. @advancedxy Could you approve this pull request?

[#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts

Maybe we should commit this to branch 0.9, too.

fix(spark): add all faulty servers into blacklist while writing for stage recomputing

Do you add a new ut for this case?

[#1658] fix(server): FileSegmentManagedBuffer#nioByteBuffer read result cacheable

Could you add a ut if this is a fix?

[#1699] improvement: Upgrade from commons-collections:commons-collections:3.2.2 to org.apache.commons:commons-collections:4.5.0-M1

@LuciferYang Could you help me review this pull request?

[#1608][part-4] feat(server)(spark3): activate partition reassign when server is inactive

In general, I want to discuss with some design ideas. What's the scope of this pull request to handle? Unhealthy node? Decomission node? You create a new concept inactive node....