incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1673] fix(K8S): Fix the deployment of stable version K8S cluster

Open jerqi opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

  1. Upgrade Go to 1.19, Because mac brew doesn't support to install older than 1.19 Go.
  2. Upgrade K8S api to 0.24. Because 1.24.1 supports to run the tests in the Mac M1 local machine and supports autoscaling/v2 api.
  3. Change v2beta2 to v2

Why are the changes needed?

Kubernetes 1.26 removed the v2beta2 api of auto scaling. So our operator can't deployed some stable version K8S cluster. So I try to upgrade the version of the client. Compatible solution will be very difficult and bring more burden to maintain. So I choose to upgrade directly. If some users use low version, they can revert this pull request and compile again.

Fix: #1673

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT + Manual test.

jerqi avatar May 11 '24 07:05 jerqi

Test Results

 2 405 files  +14   2 405 suites  +14   4h 58m 40s :stopwatch: + 1m 50s    931 tests + 3     930 :white_check_mark: + 3   1 :zzz: ±0  0 :x: ±0  10 791 runs  +37  10 777 :white_check_mark: +37  14 :zzz: ±0  0 :x: ±0 

Results for commit 079262de. ± Comparison against base commit 8e26a34e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 11 '24 08:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.05%. Comparing base (6f6d35a) to head (2a9be46). Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1694      +/-   ##
============================================
- Coverage     54.86%   54.05%   -0.81%     
- Complexity     2358     2775     +417     
============================================
  Files           368      418      +50     
  Lines         16379    21821    +5442     
  Branches       1504     2054     +550     
============================================
+ Hits           8986    11795    +2809     
- Misses         6862     9280    +2418     
- Partials        531      746     +215     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 11 '24 09:05 codecov-commenter

cc @rickyma @zhengchenyu This is a break change for your deployment, please take a look

zuston avatar May 13 '24 06:05 zuston

I verified this patch in the AWS EKS 1.28. It's ok. @advancedxy Could you approve this pull request?

jerqi avatar May 17 '24 06:05 jerqi