incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1675][FOLLOWUP] fix(test): Fix flaky tests which may cause port conflicts

Open rickyma opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Fix some flaky tests which may cause port conflicts sometimes.

Why are the changes needed?

Fix: https://github.com/apache/incubator-uniffle/issues/1675.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unnecessary.

rickyma avatar May 11 '24 16:05 rickyma

Test Results

 2 391 files  ±0   2 391 suites  ±0   4h 56m 6s :stopwatch: -44s    928 tests ±0     927 :white_check_mark: ±0   1 :zzz: ±0  0 :x: ±0  10 754 runs  ±0  10 740 :white_check_mark: ±0  14 :zzz: ±0  0 :x: ±0 

Results for commit a0052fcb. ± Comparison against base commit 8e26a34e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 11 '24 16:05 github-actions[bot]

This could be merged. Minor fixes. More stable for the test. It forgot to stop the server, which might cause port conflicts. @zuston @jerqi

rickyma avatar May 14 '24 08:05 rickyma

LGTM. Please update the PR title to describe what's this PR changed rather than coarse grained desp.

zuston avatar May 14 '24 08:05 zuston

Maybe we should commit this to branch 0.9, too.

jerqi avatar May 14 '24 10:05 jerqi

Maybe we should commit this to branch 0.9, too.

Done

zuston avatar May 15 '24 07:05 zuston