incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1699] improvement: Upgrade from commons-collections:commons-collections:3.2.2 to org.apache.commons:commons-collections:4.5.0-M1

Open rickyma opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

Upgrade from commons-collections:commons-collections:3.2.2 to org.apache.commons:commons-collections:4.5.0-M1.

Why are the changes needed?

Fix: https://github.com/apache/incubator-uniffle/issues/1699.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

rickyma avatar May 11 '24 16:05 rickyma

Test Results

 2 405 files  +14   2 405 suites  +14   4h 58m 14s :stopwatch: + 1m 24s    931 tests + 3     930 :white_check_mark: + 3   1 :zzz: ±0  0 :x: ±0  10 791 runs  +37  10 777 :white_check_mark: +37  14 :zzz: ±0  0 :x: ±0 

Results for commit 0db25f48. ± Comparison against base commit 8e26a34e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 11 '24 16:05 github-actions[bot]

PTAL. @jerqi @zuston

rickyma avatar May 16 '24 02:05 rickyma

Is this common update for other opensource projects?

zuston avatar May 16 '24 02:05 zuston

I think it is. You can refer to https://issues.apache.org/jira/browse/SPARK-37968.

rickyma avatar May 16 '24 03:05 rickyma

@LuciferYang Could you help me review this pull request?

jerqi avatar May 16 '24 06:05 jerqi

Merged into master. Thanks @rickyma

LuciferYang avatar May 17 '24 05:05 LuciferYang