James Addison
James Addison
As a strong supporter of bit-for-bit integrity without compromises: when developers report challenges producing software to adhere to some evaluation criteria (be that testability, security, performance or other), often it...
Adding one more item: debugging plugin-related issues is tricky at the moment, and I think the reason is that it's not clear/transparent what plugins are enabled for each method call....
A few more notes for a developer guide: - It'd be worth including recommendations about what the output of methods -- particularly instructions -- should look like - FAQ section?...
> Remove schema based scrapers that have no overloads I mostly agree with this, with a few small notes: - This could make incremental `mypy` progress easier, because we'd have...
> What's the scraper that incorrectly double-escapes HTML? Unfortunately I'm not sure I kept a note of that. From a quick search, I think a few sites are affected (`seriouseats`,...
>>> Remove schema based scrapers that have no overloads >> Let's try to remember to apply changes like this to the template scraper early in the process -- that way...
And after a bit more thought, two more reasons for keeping a hostname-to-scraper mapping: - For sites that _don't_ include structured recipe metadata on each page, we need a way...
Sounds ambitious, and good :) About the plugins: before removing them, would it make sense to move them onto the `AbstractScraper` as a default list? People could still override them...
I'd _like_ to introduce #650 (a migration to use [`tox`](https://tox.wiki/en/latest/)), although I'm not totally sure what everyone's opinions might be about it. Feedback appreciated!
> in case we end up with ~5 configs total, remove settings module altogether. Switch to environment flags From attempting some modifications, I'm going to suggest a small change to...