James Addison

If we roll the theming out 'centrally' (in the `basic`) theme, I'd expect that there could be some display/layout issues for some downstream themes; hopefully those problems would be reported...

@timhoffm Thanks for providing that contextual data. I'm mostly in agreement with your suggestion about leaving the basic theme as-is - providing a gradual opt-in approach seems sensible. An aspect...

> An aspect I'm puzzling over is whether we should be _even more_ cautious about affecting downstream, and not remove the `file.png` icon alongside each result (redundant though it does...

> The sphinx13 theme still got the icon styling. I plan to provide a PR for that on alabaster as well, once this PR is merged. +1 to this approach...

Ah, one more thing @timhoffm - I always forget this - please could you add an entry to the `CHANGES.rst` file to describe this feature?

Adding a note to mention that I'm still supportive of this feature. I was thinking about it again a few moments ago when considering compatibility with result grouping, if we...

By the way: if your local workflow isn't too disrupted by it, it's generally preferable to accumulate commits (including merge commits if necessary to stay up-to-date with the `master` branch)...

I'm taking a pause here @timhoffm - I'll try to continue this review (and to actually test the suggestions I'm making before adding them, when doing that) later today or...

> @jayaddison Thanks for the review! Feel free to directly push any changes. I feel, I've done all that I can for this PR, and in particular if it's JavaScript,...

@DarureTej if using PowerShell, could you try running: ```sh > Set-Item env:SPHINXOPTS "-D language=de" > .\make.bat html ``` We mention the `Set-Item` step for PowerShell in some of our ['advanced...