Results 767 comments of James Addison

Would the following be an improvement for developer experience, or would it be a misguided attempt to make the code more Pythonic? ```python class Template(AbstractScraper): # The self.soup object provides...

A `pyproject.toml` migration is ready for review in #655. After comparing the `poetry` and `setuptools` approaches, and learning various backwards compatibility and workflow questions related to them, I think that...

I'm going to take some time out from maintenance/dev work here for a week or two. I feel like I've been commenting a lot and thinking/attempting a lot of stuff,...

> remove the "plugins" idea altogether Maybe there'd be an alternative implementation, but after getting back into the code again recently - I do think that the plugins are useful....

Maybe controversial opinion: I think that the `v15` branch should include a breaking change where `instructions()` returns type `list[str]` (instead of a newline-joined `str`), mirroring `ingredients()`. Making those two methods...

I've pushed commit 0b87a5141a0d5497566425110d6d7947ad1bc76f to the `v15` branch -- it removes the `scrape_me` interface, meaning that the library doesn't have any network dependencies. Is that good/bad? Is it a developer...

> Move away "networking" code and allow easy usage of the package with async/proxies/timeout (we should leave an example code too). no demo with javascript/browser check bypass. Just making a...

Ah, no I haven't - v15.0.0-rc1 is completely network-isolated, but the suggestion there was to include a utility method to do the HTTP retrieval. I'll do that for `rc2` (it'll...

Also: the `scrape_html` method can probably be simplified further in `v15` to remove some of the proxy/timeout logic. That can move into the suggested utility method.

> * Remove schema based scrapers that have no overloads: They generate no value since they use the default schema implementation, but we have the tests that prove they work....