K. S. Ernest (iFire) Lee

Results 1266 comments of K. S. Ernest (iFire) Lee
trafficstars

I'm here. Let me review. Edited: Was away over the weekend.

Can you run `pre-commit run -a`? https://docs.godotengine.org/en/stable/contributing/workflow/pr_review_guidelines.html https://docs.godotengine.org/en/stable/contributing/development/code_style_guidelines.html#doc-code-style-guidelines

Try the earlier instructions about installing pre-commit to adjust style

> Import the images if the fbx model had external images. for example it tries to import png files using resource loader. > > Is importing images also an extension...

@Sailanarmo Can you make a new issue & pull request if encounter the compiler errors?

Does anyone know if using Vector instead of pointers causes audio corruption? I don't understand why AudioStreamMP3 doesn't match AudioStreamWAV and AudioStreamPlaybackWAV.

> Moving the writer directly after scene gdextension initialization fixes this, but I'm unsure if it's a clean solution or if the writer is selected directly after the render server...

I agree that using "positive" boolean math is better, but I don't know why we're doing this. Is there a bug or issue relating to this by the general godot...

The standard way to serialize Node or a tree of Node is PackedScene. > I think it might make more sense from a phraseology standpoint to call these from_variant or...