Results 83 comments of David Handermann

It looks like the current build is failing due to differing parent POM versions. Recommend rebasing against the current main branch, which would be a good time to squash commits...

@lizhizhou It looks like the latest updates included many historical commits, please rebase and force-push to correct the branch history.

Thanks for adding the `Time Field` property @lizhizhou. To simplify the final stages of the review, can you squash all changes into a single commit? The current list of 27...

Thanks for working on this @p-kimberley, closing for now based on comments about waiting for a review of current handling of parent record nodes. Feel free to reopen when that...

Thanks for the work on this @r65535, and thanks for the updates @dan-s1. I will take a look at the updates today, it appears close to completion.

Thanks for summarizing this issue @rasantel. Unfortunately just moving the `doKex()` invocation is unlikely to provide a reliable solution. The heartbeat process runs in a separate thread, so I believe...

> Thanks for checking, @exceptionfactory . Yes, the heartbeater still runs in its own thread, but by starting that thread after the key exchange completes, this change guarantees that it...

> @exceptionfactory I updated the PR to address the possibility of this same bug happening during re-keying. I generalized the solution to add `IGNORE` to the cases in which `TransportImpl.write`...

@sumitsum Could you provide some additional details around intended use cases for PKCS12? The format support multiple entries, including both standalone certificates and private keys with certificates. A PKCS12 reader...

That's a good question about OpenSSH and other services. Certificate-based authentication with OpenSSH does not use the standard X.509 structure for certificates, so even that scenario does not seem like...