nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-7392: Add ValidateJson processor to standard bundle

Open r65535 opened this issue 3 years ago • 4 comments

Summary

NIFI-7392

This PR adds a ValidateJson processor to the standard bundle. It validates flowfiles against a JSON schema.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [x] Pull Request based on current revision of the main branch
  • [x] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [x] Build completed using mvn clean install -P contrib-check
    • [x] JDK 8
    • [ ] JDK 11
    • [ ] JDK 17

Licensing

  • [x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [x] Documentation formatting appears as expected in rendered files

r65535 avatar Aug 26 '22 11:08 r65535

Thanks for submitting a new pull request for this processor @r65535!

Before reviewing the details, there appears to be a test failure in the automated build on Windows.

Fixed - the JSON library supports French and English validation output, and my unit tests were validating the English content. My bad!

r65535 avatar Sep 01 '22 08:09 r65535

@exceptionfactory - do you mind taking a look at this PR? I'm keen to get it merged into the nifi code base, if possible!

r65535 avatar Sep 27 '22 14:09 r65535

@r65535 Can I help in anyway? As I mentioned before I am excited to see the development of this processor as this is exactly what we need for some of our flows. I know you did the lion's share of the work. If there is anything I can assist with please do not hesitate to reach out. Thanks!

dan-s1 avatar Sep 29 '22 18:09 dan-s1

@r65535 Do you have any questions on the feedback provided?

exceptionfactory avatar Oct 10 '22 16:10 exceptionfactory

@exceptionfactory When you get a chance can you please review the changes I made? Thanks!

dan-s1 avatar Nov 08 '22 01:11 dan-s1

@dan-s1 - thanks for making the changes to this PR! 🥳

@exceptionfactory - do you think we could get this merged in for the 1.19.0 release?

r65535 avatar Nov 16 '22 12:11 r65535

Thanks for the work on this @r65535, and thanks for the updates @dan-s1. I will take a look at the updates today, it appears close to completion.

exceptionfactory avatar Nov 16 '22 14:11 exceptionfactory

Thanks for helping us get this over the line @exceptionfactory!

r65535 avatar Nov 16 '22 16:11 r65535

@exceptionfactory Thanks again for all the suggestions you made for reviewing and approving!

dan-s1 avatar Nov 16 '22 16:11 dan-s1