Results 83 comments of David Handermann

@StanRichie This issue sounds similar to the problems reported in issue #895. In that case, the runtime version of Bouncy Castle was not new enough, resulting in the failures described....

@leefine Can you provide the version of Bouncy Castle you are using? The X25519 algorithm should be supported since version 1.61 of Bouncy Castle.

@devaskim and @leefine, please provide more details on the runtime dependency configuration and Java version if you would like to receive additional help on this issue. The specific Java version...

Thanks for the additional details @devaskim. If you could provide the details of the class signature error, that would be helpful. The latest version of the Bouncy Castle Provider library...

Thanks for the note and stack trace @hfhbd. The `NoClassDefFoundError` indicates that the Bouncy Castle `AlgorithmIdentifier` is not available at runtime. This class is in the `bcutil-jdk18on` library. Although the...

SSHJ Pull Request #838 replaced a custom class with the standard `X25519` implementation available through configured Java Security Providers. This is available by default on Java 11 and following, but...

@elwira-zimoch The `close()` method in the anonymous class appears to be effectively calling close twice: 1. `try (file) {` is a try-with-resources, which calls `RemoteFile.close()` 2. `finally { file.close(); }`...

You're welcome @elwira-zimoch. As both `RemoteFile` and `RemoteFileInputStream` implement or extend standard interfaces (`Closeable` and `InputStream`), the best approach is to follow standard strategies for handling those types of resources.

The [SSHClient.auth()](https://github.com/hierynomus/sshj/blob/master/src/main/java/net/schmizz/sshj/SSHClient.java#L217) method supports the ability to provide multiple types of authentication methods, including password and public key authentication. [Apache NiFi](https://github.com/apache/nifi) has components that implement this approach. The [StandardSSHClientProvider](https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ssh/StandardSSHClientProvider.java#L91) class...

@noblehelm I submitted pull request #861 to address the Bouncy Castle registration issue. Part of the problem with the current approach is that the default configuration requires Bouncy Castle to...