nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor

Open p-kimberley opened this issue 3 years ago • 1 comments

Summary

NIFI-10646

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [X] Pull Request based on current revision of the main branch
  • [X] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [ ] Build completed using mvn clean install -P contrib-check
    • [ ] JDK 8
    • [ ] JDK 11
    • [ ] JDK 17

Licensing

  • [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ ] Documentation formatting appears as expected in rendered files

p-kimberley avatar Oct 15 '22 05:10 p-kimberley

Attempted mvn -Pcontrib-check clean install, however current main branch is failing with errors about unapproved licenses:

NIFI-10646 Handle failed GeoIP lookups in `GeoEnrichIPRecord` processor

License failures are related to nifi-commons/nifi-vault-utils module.

p-kimberley avatar Oct 15 '22 05:10 p-kimberley

The GeoIP enrichment unit tests are what's failing now.

MikeThomsen avatar Oct 20 '22 10:10 MikeThomsen

Awaiting review by @mattyb149 into current handling of non-existent parent record nodes.

Will revisit this PR once that is completed.

p-kimberley avatar Oct 20 '22 15:10 p-kimberley

Thanks for working on this @p-kimberley, closing for now based on comments about waiting for a review of current handling of parent record nodes. Feel free to reopen when that is addressed, or when you have evaluated additional changes to unit tests.

exceptionfactory avatar Jan 12 '23 17:01 exceptionfactory