solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-16287 : MapStream - remap tuple value(s)

Open danrosher opened this issue 3 years ago • 4 comments

https://issues.apache.org/jira/browse/SOLR-16287

Description

Enables atomic updates for update stream by remapping a value to tuple, solr will recognise the map as an atomic update, otherwise update stream simply overwrites. Normal Solr requirements for atomic/in-place updates are still necessary.

Solution

Remap from (k,v) => k -> newKey -> value

e.g. with

map(,"cand_id=add-distinct") , convert stream tuples from

From: {"cand_id":5718,id:123,v_i:345} To: { id:123, v_i:345, "cand_id": { "add-distinct": 5718 },

Tests

e.g. With: new UpdateRequest() .add(id, "1", "a_ss", "foo", "b_i", "1", "c_d", "3.3", "d_b", "true") Then: update(collection1,map(tuple(id="1",a_ss="bar"),"a_ss=add-distinct")) will add-distinct 'bar' to a_ss to then contain ['foo','bar']

Checklist

Please review the following and check all that apply:

  • [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [x] I have created a Jira issue and added the issue ID to my pull request title.
  • [x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [x] I have developed this patch against the main branch.
  • [ ] I have run ./gradlew check.
  • [x] I have added tests for my changes.
  • [x] I have added documentation for the Reference Guide

danrosher avatar Jul 12 '22 09:07 danrosher

Docs are looking nice!

epugh avatar Jul 14 '22 15:07 epugh

I sent a note to dev mailing list to see if @joel-bernstein can review it ;-) If he can't, I can try, but it's just an area I haven't worked much in!

epugh avatar Jul 22 '22 22:07 epugh

Let's give it another few days, and then, if I don't review/merge it, can you bug me? Say Thursday??? Thanks for this @danrosher

epugh avatar Jul 26 '22 13:07 epugh

Will do @epugh . I'll be away for a week after that.

danrosher avatar Jul 26 '22 14:07 danrosher

@epugh ping ;) slightly more than a week or so. anything left to do here?

risdenk avatar Oct 27 '22 18:10 risdenk

FYI, Joel is going to merge this once the new jar for streaming is completed.

epugh avatar Oct 31 '22 14:10 epugh

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Feb 19 '24 00:02 github-actions[bot]