solr icon indicating copy to clipboard operation
solr copied to clipboard

Published 20 hours ago • verified publisher icon apache

SOLR-16318: Use up to JDK 11 features (avoid type declaration when <> can be used)

Open cpoerschke opened this issue 3 years ago • 1 comments

Description

  • Avoid type declaration when <> can be used

Pull request history

sub-set of the current #912 changes, experimentally identified with a ./dev-tools/scripts/branchSplitter.py 56842452026 script run (script included in the branch history but not in the branch content itself).

the script retains in the branch only changes which appear 'simple to review' (in this case differences that look like template argument removals or additions).

running just ./dev-tools/scripts/branchSplitter.py identifies what could be split, running with a commit argument does the actual split by reverting back to the named commit point files that changed but not in a 'simple to review' way.

cpoerschke avatar Jun 24 '22 19:06 cpoerschke

Makes sense to me... I wonder if we need to have a conversation on dev mailing list related to when we merge this? I know @dsmiley is interested in seeing #943 get merged soon, and this might impact that.

epugh avatar Jul 29 '22 16:07 epugh

I would love to see these get merged, as keeping this patch up to date is going to get harder... Do we have consensus on merging it?

epugh avatar Sep 06 '22 22:09 epugh

I would love to see these get merged, as keeping this patch up to date is going to get harder... Do we have consensus on merging it?

Just resolved the merge conflict. And noting that #943 is merged now, is now more convenient then to proceed to merging here? @dsmiley WDYT?

And a question for all, we're planning to cherry-pick from main to branch_9x also for these changes, right?

cpoerschke avatar Sep 14 '22 16:09 cpoerschke