Eric Pugh
Eric Pugh
Does this change need a unit test?
@tboeghk I'm still interested in this one getting in ;-). And it's post š° season! ;-)
Thank you StaleBot..... I just checked the JIRA and I was last to chime in, so I'll take this and try and get it over the finish line.
Thank you @dsmiley for reviewing this PR... I'm excited for the work @iamsanjay has been doing, and I do NOT feel comfortable reviewing/merging code in this area ;-)
@piuma I would be interested in picking this back up if you could contribute a BATS test demonstrating the error first. That would make verifying the fix a lot easier...
Longer term, we want to rethink how our `start` and `stop` commands are managed. There is definitly better ways of handling them, including moving more shared logic into Java code...
> The old "User Managed" mode is still supported (https://solr.apache.org/guide/solr/latest/deployment-guide/user-managed-distributed-search.html), so I would not remove it. Guess it's there to give a reason why SolrCloud was introudced. > > But...
@jebnix thanks for this, and don't forget to ping me on any outstanding PR's you might have ;-)
If you are looking for an idea... We want to rename "User Managed" to "standalone" through the ref guide ;-). And move the SolrCloud examples above the standalone examples instead...
Is this the only place where this is needed? Or are there lots of directories similar?