solr icon indicating copy to clipboard operation
solr copied to clipboard

Remove the Before SolrCloud section, and expand the supported feature…

Open jebnix opened this issue 3 years ago • 3 comments

…s section instead

https://issues.apache.org/jira/browse/SOLR-XXXXX

Description

There is a pretty confusing section that explains what existed before SolrCloud. That's pretty redundant now since this is pretty old.

Solution

Remove the Before SolrCloud section, and expand the supported features section instead

Tests

Checklist

Please review the following and check all that apply:

  • [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [x] I have created a Jira issue and added the issue ID to my pull request title.
  • [x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [x] I have developed this patch against the main branch.
  • [x] I have run ./gradlew check.
  • [x] I have added tests for my changes.
  • [x] I have added documentation for the Reference Guide

jebnix avatar Oct 26 '22 20:10 jebnix

The old "User Managed" mode is still supported (https://solr.apache.org/guide/solr/latest/deployment-guide/user-managed-distributed-search.html), so I would not remove it. Guess it's there to give a reason why SolrCloud was introudced.

But perhaps it should be reworded and make it clear that the feature still exists? "Before SolrCloud, solr only supported Distributed Search through <User managed mode>(link)....."

janhoy avatar Jan 13 '23 13:01 janhoy

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Feb 18 '24 00:02 github-actions[bot]

@jebnix Do you want to give it a final stab?

janhoy avatar Feb 18 '24 14:02 janhoy

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

The old "User Managed" mode is still supported (https://solr.apache.org/guide/solr/latest/deployment-guide/user-managed-distributed-search.html), so I would not remove it. Guess it's there to give a reason why SolrCloud was introudced.

But perhaps it should be reworded and make it clear that the feature still exists? "Before SolrCloud, solr only supported Distributed Search through (link)....."

So I am re-reading things... And we start out with a section "Solr Cluster Types" that talks about the various options. Then you get the section on "User-Managed Clusters" and then "SolrCloud Clusters". I feel like if you are this page, you don't need this content, because the differences is covered in "Solr Cluster Types", we are just derailing someone at this point... Thoughts? Does that change your mind on merging this PR?

epugh avatar May 03 '24 07:05 epugh

I have not reviewed the other pages related to cluster types, but trust you that this might be redundant. It's a pity that doc improvements get stalled. Feel free to land it.

janhoy avatar May 03 '24 08:05 janhoy

@jebnix thanks for this, and don't forget to ping me on any outstanding PR's you might have ;-)

epugh avatar May 03 '24 16:05 epugh

If you are looking for an idea... We want to rename "User Managed" to "standalone" through the ref guide ;-). And move the SolrCloud examples above the standalone examples instead of below them ;-)

epugh avatar May 03 '24 16:05 epugh