[SOLR-17187] Add possibility to supply a custom commitPollInterval for TLOG/PULL replicas

[tboeghk]

https://issues.apache.org/jira/browse/SOLR-17187

Description

In TLOG/PULL replica setups with longer commit intervals it would be great to configure the interval to check for new commits manually to tune to your setup. Currently on the PULL replica the interval to check for new commits is computed using the commit / soft commit settings

Solution

You can now supply a custom commitPollInterval in your updateHandler definition. If supplied, this takes precendence over the one calculated from hard/soft commit settings.

<updateHandler class="solr.DirectUpdateHandler2">

    <!-- For TLOG replicas, updateLog must be enabled -->
    <updateLog>
        <str name="dir">${solr.ulog.dir:}</str>
    </updateLog>

    <!-- custom poll interval fix -->
    <commitPollInterval>00:00:10</commitPollInterval>
</updateHandler>

Tests

None :-/

Checklist

• [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• [x] I have created a Jira issue and added the issue ID to my pull request title.
• [ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
• [x] I have developed this patch against the main branch.
• [x] I have run ./gradlew check.
• [ ] I have added tests for my changes.
• [ ] I have added documentation for the Reference Guide

[epugh]

Looks like some feedback @tboeghk that could be addressed and then maybe this would be ready for commit!

[epugh]

Does this change need a unit test?

[tboeghk]

@cpoerschke is absolutely right, I added it "the hacky way". I'll extract the config setting the proper way 👍

With that, a unit test is easy to add @epugh 👍

I'll update the docs also as soon as I'm back at my desk (after Easter)

[github-actions[bot]]

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

[epugh]

@tboeghk I'm still interested in this one getting in ;-). And it's post 🐰 season! ;-)

[github-actions[bot]]

This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. Thank you for your contribution!