Eric Pugh

Results 603 comments of Eric Pugh

@mkhludnev before I commit this to `main` only, are you able to give this a test on Windows?

I think this branch has definitly had some bit rot, and there is a lot of work to update it.... Thanks for looking @mkhludnev at this branch, glad to get...

I updated this PR (thanks StaleBot for bugging me) from Main, and I think have to redo some changes...

@mkhludnev could you take a look again now that I've updated the PR and pushed up a fix for the host and help discrepancies? Also, if anyone has windows experience,...

Before calling this done, make sure to check out https://github.com/apache/solr/pull/1768/commits/395eaab7199f5f531f6a4121f4e946456ff5c5ad and make sure all the reverted changes (when bringing this PR up to date) are reapplied!

Pending a good run off all the tests, I think I'm done and would love some review. This is to go into Solr X and not be backported to Solr...

Thanks @janhoy for starting to look. And yeah, this is 10x only change. Trying to manage two sets of old and new parameters I think would just make this impossible...

> Is it possible to back port the non-conflicting ones to 9.x? And also log deprecation warnings on anything that's going away? I was sort of hoping not too... I...

> My ideal world is everywhere that we remained -x to -y we add -y to 9.x and log a warning on usage of -x. Similar to what gradle does....

One reason I've been feeling a bit daunted on the idea of enhancing commons-cli to support deprecation is because it would mean that we would need to keep/extend the lines...