Brian Devins

Results 70 comments of Brian Devins

someone had stubbed it out, I really just fixed the Calendar/Date implementation that was there since all (most) of the Date manipulation functions are deprecated

We have users that depend on the metrics and prometheus endpoints for sure. Even including those in the list in this PR would be a breaking change. Zipkin is not...

We use well known names, DNS for HTTP and `zipkin` for our kinesis queue name

Awesome Adrian, this is the first time I've ever bookmarked a GitHub issue

I don't use the `ES_AWS_DOMAIN` variable but in order to do that, you just give it the name of the ES domain as it gets displayed in the console, not...

Ok, your example in the issue does not reflect what you just said. In case we are misunderstanding each other. Instead of: `ES_AWS_DOMAIN="https://search-elk-test-.eu-west-1.es.amazonaws.com"` You use: `ES_AWS_DOMAIN="search-elk-test` It will also need...

Turns out there is a missing feature in the nodejs grpc library: https://github.com/grpc/grpc/issues/8767

Their approach overall is quite nice, if I end up with time I'll take a crack at implementing it. If someone else gets to it first: https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/blob/master/src/hooks/userspace/hook-grpc.js

If you are already using spring cloud, you are probably better off using spring-cloud-sleuth with the components Adrian mentioned. Though a disclaimer is in order here: the XRay reporter does...

For those asking for support, what would that look like to you? Part of the difficulty here is deciding where to create spans, how to handle workflow steps, how to...