Brian Devins

Results 70 comments of Brian Devins

You'll just want to update the end date on the license header. Sorry, this isn't documented because it only happens once a year.

While I agree, thats for the GUI programmers to handle which I am not. This get me closer to what I want. Ideally there would be a "Pokemon Power" sorter...

I had been running it until the API lockdown. I have some code I haven't pushed up and it isn't configurable at all for and end user. On Sun, Jul...

@jabbink should I do a rebase on this to clean up the commit history?

@jabbink since #939 was merged in, should I refactor this around that implementation?

The intent is that you create one HttpTracing instance without serverName set, since it is used for server side operations as well. Then you copy it for each client that...

It is definitely intended that you can't set serverName on the non-copy version of HttpTracing. If you could then you could break server tracing. Can you maybe explain why creating...

For not breaking server tracing, please see https://github.com/openzipkin/brave/blob/5be287b91c3d18da9fc7a597d71b12b27be6043c/instrumentation/http/src/main/java/brave/http/HttpTracing.java#L244 The API is set up in a way that it is not possible to have an instance of `HttpTracing` that has a...

Borrowing from census it might make sense to have it be `brave.mode` where options are: `ENABLED`, `NOOP`, and `DISABLED` since people might want to disable things completely