Brian Devins

Disabled to me would mean: no trace ID generation and no propagation of any kind

This is a necessary feature for us in the apps that are on plain brave, my work on opentracing has lead me toward creating a `Tracer` that applies our metadata...

Excellent Adrian, I'll be playing with this in our starter. I think this would work really nicely alongside the pattern soundcloud uses: https://developers.soundcloud.com/blog/using-kubernetes-pod-metadata-to-improve-zipkin-traces I would recommend adding as little to...

I'm a -1 on the name `brave-instrumentation-jdbc`, if there is going to be a module that is named that I think it should be an abstraction module like `brave-instrumentation-http` I...

Oh I didn't realize this was here, I think I may have done redundant work when I built: https://github.com/spring-cloud/spring-cloud-sleuth/pull/1218 EDIT: nevermind. I saw this code. I'll try to compose my...

Chiming in with a small idea, this seems like the correct use case for the OT follows-from relationship type. That way parent-child is maintained, but the relationship is also captured,...

I actually meant exactly what you said, I think it should be a tag that potentially we assign special meaning to in the UI, but leaves the data model alone....

Actually based on the fact they have actually defined the meaning of that reference type, it was a TODO last I saw, this is not a case that matches that...

This crept up again in: https://github.com/openzipkin/brave/pull/834 - note the PR was a doc change

I'm gonna build a smoke test for keycloak, what version of it are you running?