langchain icon indicating copy to clipboard operation
langchain copied to clipboard

fixes #1214

Open cs0lar opened this issue 2 years ago • 5 comments

Background

Continuing to implement all the interface methods defined by the VectorStore class. This PR pertains to implementation of the max_marginal_relevance_search_by_vector method.

Changes

  • a max_marginal_relevance_search_by_vector method implementation has been added in weaviate.py
  • tests have been added to the the new method
  • vcr cassettes have been added for the weaviate tests

Test Plan

Added tests for the max_marginal_relevance_search_by_vector implementation

Change Safety

  • [x] I have added tests to cover my changes

cs0lar avatar Apr 17 '23 07:04 cs0lar

how big is the new integration test file?

dev2049 avatar Apr 24 '23 16:04 dev2049

@dev2049 which do you mean, this one: tests/integration_tests/vectorstores/test_weaviate.py ? this integration test also add cassettes files

cs0lar avatar Apr 24 '23 16:04 cs0lar

@dev2049 which do you mean, this one: tests/integration_tests/vectorstores/test_weaviate.py ? this integration test also add cassettes files

this one, seems like it's 200k lines tests/integration_tests/vectorstores/cassettes/test_weaviate/TestWeaviate.test_similarity_search_without_metadata.yaml

dev2049 avatar Apr 24 '23 17:04 dev2049

@dev2049 hmm... good spot! that doesn't look right. I'll check it out.

cs0lar avatar Apr 24 '23 17:04 cs0lar

fixed! The cassette was picking up the weaviate initialisation in the docker container, so after making sure the container was up and the weaviate instance had processed some jobs I re-ran the tests and saved the new cassette. Thanks for spotting that @dev2049 !

cs0lar avatar Apr 24 '23 17:04 cs0lar