langchain
langchain copied to clipboard
fixes #1214
Background
Continuing to implement all the interface methods defined by the VectorStore class. This PR pertains to implementation of the max_marginal_relevance_search_by_vector method.
Changes
- a
max_marginal_relevance_search_by_vectormethod implementation has been added inweaviate.py - tests have been added to the the new method
- vcr cassettes have been added for the weaviate tests
Test Plan
Added tests for the max_marginal_relevance_search_by_vector implementation
Change Safety
- [x] I have added tests to cover my changes
how big is the new integration test file?
@dev2049 which do you mean, this one: tests/integration_tests/vectorstores/test_weaviate.py ? this integration test also add cassettes files
@dev2049 which do you mean, this one:
tests/integration_tests/vectorstores/test_weaviate.py? this integration test also add cassettes files
this one, seems like it's 200k lines tests/integration_tests/vectorstores/cassettes/test_weaviate/TestWeaviate.test_similarity_search_without_metadata.yaml
@dev2049 hmm... good spot! that doesn't look right. I'll check it out.
fixed! The cassette was picking up the weaviate initialisation in the docker container, so after making sure the container was up and the weaviate instance had processed some jobs I re-ran the tests and saved the new cassette. Thanks for spotting that @dev2049 !