Daco Harkes

Results 402 comments of Daco Harkes
trafficstars

Given we have a merged https://github.com/dart-lang/native/tree/main/pkgs/swiftgen, I presume this can be closed.

Oh, it's an empty directory, my bad! (I was in overzealous [spring-cleaning](https://en.wikipedia.org/wiki/Spring_cleaning)-mode!)

A variant of 1. that's more user-friendly: `BuildConfig.sharedOutputDirectory` that automatically lives in `.dart_tool/native_assets_builder/`

API design: ```dart // Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file // for details. All rights reserved. Use of this source code is governed by...

> `await runUnderDirectoryLock(` Thinking about this, the shared directory should be locked in the native assets builder, due to https://github.com/dart-lang/native/issues/1534. Otherwise, the native assets builder could be copying the assets...

Note from discussion with @HosseinYousefi: `config.outputDirectoryShared` is shared across all invocations of the same hook, `config.outputDirectory` is shared across only invocations that are 100% identical config. But we might have...

We have `input.outputDirectoryShared`, and we have decided to invoke hooks per asset type. * https://github.com/dart-lang/native/issues/1739

> We shouldn't run it - or what do you mean? Well the test simply fails in the link hook because it's only supported on Linux. And the test has...

@bdero Just a heads up, we might break the metadata soon (or temporarily remove it until we find an API that we want to add to do this). As a...

I thought I had posted an API sketch here earlier, but apparently I didn't. My current way of thinking is: ```dart void addAsset( Asset asset, { Iterable? dependencies, bool forBuildHooks,...