Daco Harkes

Results 402 comments of Daco Harkes
trafficstars

This requires validation in the native assets builder. The `BuildConfig` doesn't have the info about which linkers are available, so checking inside `build( ... )` doesn't work. (Unless we add...

> [This check](https://github.com/dart-lang/native/actions/runs/12241359055/job/34146636294) will fail until https://dart-review.googlesource.com/c/sdk/+/381580 is in the latest dev release. Add a skip with a TODO. Otherwise the CI is going to be red all the time....

It seems that renaming on Linux might be much harder than renaming on MacOS/iOS. See the discussion on https://github.com/dart-lang/native/issues/190#issuecomment-2304312550.

https://github.com/flutter/flutter/pull/158214 added duplicate code asset checks to flutter_tools. Thanks @mkustermann! 🙏

Cool, reading those annotations and generating version checking code is a cool idea!

> `platform.version` Isn't that the Dart version instead of the OS version?

@hkaripineni What version of Dart are you running on?

Closing out old stale PRs. Feel free to reopen if still relevant.

I believe we don't want to expose those classes. Instead the field should should be exposed on `Allocator`: * https://github.com/dart-lang/sdk/issues/55571 Unless, we want to communicate that the `nativeFree` is non-nullable...

I thought we had an issue to track that we should add a validation step, but I can't find it. There's a bunch of other things to verify: * assetsForLinking...