Daco Harkes

Results 411 comments of Daco Harkes
trafficstars

Benchmarks that benchmark individual `dart:ffi` features are in https://github.com/dart-lang/sdk/tree/main/benchmarks. Benchmarks that benchmark how long it takes to run FFIgen code generator can live on this repo in pkgs/ffigen/benchmark. This issue...

> Is there a good framework for continuous benchmarking? Maybe we can teach https://github.com/benchmark-action/github-action-benchmark to understand the output of https://pub.dev/packages/benchmark_harness. github-action-benchmark can leave comments on PRs if the benchmark results...

> I see there was previous discussion of this in #1360, but I don't think that telling each developer to handle this is the right outcome if the goal is...

WDYM maintain? It's code generated by FFIgen. The larger design approach is that for every single thing that cannot be expressed in Dart (writing adaptors for native finalizers with different...

The version needs to change to `2.1.4-wip` in pubspec and changelog.

This was changed in https://github.com/dart-lang/native/pull/946 based on feedback from @mosuem that having the `package:$packageName/$name` is bad usability. If I remember correctly, the wish was to have the package name be...

> If we have an invariant that any asset ID must start with `package:` then one could even think of leaving that part away, since it's redundant information. Hm, that's...

Notes from discussion today. The majority prefers having separate arguments/getters over exposing the assetID string. And we should ensure that we then do the same everywhere. A hopefully exhaustive list:...

> form a global name space Yes. We _can_ rename files and rewrite dynamic linker imports for iOS/MacOS, but not for Linux. https://github.com/dart-lang/native/issues/1425 > We wouldn't require the package name...

> => Can it be that linker isn't re-run when the build outputs to the linker change? Probably, and apparently this is not covered by a test case. Edit: Yep,...