native icon indicating copy to clipboard operation
native copied to clipboard

test pkgs/native_assets_builder/test/build_runner/link_test.dart fails on MacOS

Open dcharkes opened this issue 1 year ago • 2 comments
trafficstars

The following fixes the test suite for MacOS:

  test('treeshaking assets using CLinker',
      timeout: longTimeout,
      skip: Platform.isMacOS || Platform.isWindows, () async {

@mosuem are we not running this test suite on the CI for MacOS?

dcharkes avatar Jul 31 '24 10:07 dcharkes

We shouldn't run it - or what do you mean?

mosuem avatar Jul 31 '24 13:07 mosuem

We shouldn't run it - or what do you mean?

Well the test simply fails in the link hook because it's only supported on Linux. And the test has no skip or early returns for other OSes. I don't suppose we should run it if it will simply fail?

dcharkes avatar Jul 31 '24 14:07 dcharkes