native icon indicating copy to clipboard operation
native copied to clipboard

When build output changes linker has to re-run

Open mkustermann opened this issue 1 year ago • 1 comments
trafficstars

Assuming I have a correct build with two data assets with (id1, a.txt) and (id2, b.txt). I then change the hook/build.dart to use (id1, a.txt) and (id2, a.txt) (same ids but now also same file uri).

Then I observe the hook/build.dart to be re-run, which will result in a different build output. But the linker step is not re-run, despite the build output changing, instead it prints

Skipping link for ... in ..... Last build on 2024-08-09 14:06:27.000. Last dependencies change on 2024-08-09 13:43:27.000. Last hook change on 2024-08-09 13:35:20.000.

=> Can it be that linker isn't re-run when the build outputs to the linker change?

/cc @dcharkes

mkustermann avatar Aug 09 '24 12:08 mkustermann

=> Can it be that linker isn't re-run when the build outputs to the linker change?

Probably, and apparently this is not covered by a test case.

Edit: Yep, no test coverage: https://github.com/dart-lang/native/pull/827 pkgs/native_assets_builder/test/build_runner/link_test.dart (only non caching tests)

dcharkes avatar Aug 09 '24 15:08 dcharkes