Davide Fioriti

Results 219 comments of Davide Fioriti
trafficstars

I've been experimenting on the git reset usage, mainly out of curiosity. Potentially it is not that bad, see https://github.com/pypsa-meets-earth/pypsa-earth/compare/main..davide-f:pypsa-earth:test_reset_merge2 Note that despite it looks "nice" it shall be improved....

Just looking there is only one possible downside of options 1 and 3*: line contributions do not match the past repo. As we squash meshed the commit anyone who contributed...

Great exploration @siddharth-krishna !!!

I tested Option 2 in this PR: https://github.com/davide-f/pypsa-earth/tree/main that in terms of changes it is basically perfect: https://github.com/pypsa-meets-earth/pypsa-earth/compare/main..davide-f:pypsa-earth:main Using the procedure as follows: ``` bash git reset 3d6365ac6af69b86fcadb1de9809ed09986e654f git push...

Today we met with @ekatef and @hazemakhalek and we are of common agreement that option 3b shall be the way to go. The reason being that it is extremely easier...

This is the option I talked you about to increase the distance of the merged nodes. This may be relevant, for example, for the isolated node on the bottom left...

For this issue I think there is no easy solution. My feeling is that we could add an option in the config to disable remove_stubs. The major concern in my...

Can we close this issue? we have the option about remove_stubs and when sometimes that happens, it is due to missing network data.

Closing and reopening if needed as it is the intended effect of remove_stubs that in some use-cases leads to side-effects