Davide Fioriti

Results 219 comments of Davide Fioriti
trafficstars

By incorporating the other PRs on #650 and #829, the overall workflow for US takes less than 4h with a total memory compatible with a medium laptop :) I'll be...

This PR, after all the recent changes, achieves an objective value of 2.51e+9 on the tutorial that compares well to 2.54e+9 in https://github.com/pypsa-meets-earth/pypsa-earth/actions/runs/12447612841/job/34751281672 Difference is acceptable for me

Sorry, I got a bit confused among the PRs. Indeed I already reviewed it and it seemed fine, although there is a pending comment (specify minimum pypsa version) To understand...

Regarding the overall approach, the proposal is totally fine! Agree that it is advisable to merge the two PRs and have one.

> As a technical comment, the CI currently fails for mac with `conda: command not found`. Not sure if it's related to replacement of `conda` with `mamba` in a CI...

@GbotemiB I've found a small fix with csp. The error is attached. [ERROR_helpersAn error happened in m.txt](https://github.com/user-attachments/files/16532467/ERROR_helpersAn.error.happened.in.m.txt) Since you worked on it, it would be great to have your opinion....

Regarding this tracking, I summarize here past discussions in the initiative. This PR combines multiple different features some of them are quite good in spirit but may be better reviewed...

> Hello! @davide-f thanks for taking care about this part. The implementation looks great. Do you have any objections if we'll merge this PR? 🙂 > > That is a...

Many thanks everyone! I understand with Katia this pr needs to be merged (see the other pr). I'll revise and fix it soon. @cshearer1977 does this pr fix most of...