Davide Fioriti

Results 219 comments of Davide Fioriti
trafficstars

Good point Katia and thanks for the review. For consistency with pypsa-eur, we can keep it this way. In the current HVDC network there is nothing attached to the DC...

As also katia agree, let's merge it as is :) Great and many thanks

Wow! That is a quite big bug! Thanks for reporting. Indeed this shouldn't be difficult as that was our previous configuration

Hello @SermishaNarayana :D Just commentng to check your expectations on this PR. If you wish I can cherry-pick this and finalize or feel free to resolve the comments above and...

> Hi @davide-f , I performed the additional checks you requested on both USA and Nigeria (which is not actually affected by the changes in `add_electricity.py`) and everything seems to...

@danielelerede-oet weren't you using the default configurations for the tests?

Great @danielelerede-oet :D Many thanks for the PR! As the merge/remerge issue is solved, this can be finally merged :)

> @davide-f I integrated the changes you suggested as discussed, but 1) we also added more tests and 2) now we have passed all the checks. Any other suggestions? To...

Hello :) Just posting here to align on the expected steps on this to facilitate the review, if deemed useful. We believed this feature is interesting for upstream, as it...