Davide Fioriti
Davide Fioriti
> Hi @davide-f and @enricogiglio, > > okay, we've finally had a closer look, thanks for the contribution! Extendability and committability at the same time would be a good feature...
Hello @lkstrp :) As v1.0 is out, I can come back here when time is appropriate as discussed. To clarify the difference of features: 1. #1367 aims to allow the...
> @davide-f many thanks for you comment and clarification! I really like the approach of allowing a generator representing a fleet of modular units, a powerful feature. > > After...
@lkstrp I've been exploring the diff of this PR with respect to https://github.com/PyPSA/PyPSA/pull/1367: https://github.com/PyPSA/PyPSA/compare/committable-extendable...enricogiglio:PyPSA:AdvancedModularity there are some unexpected differences on documentation and pre-commit. Just sharing to be sure the differences...
Many thanks @lkstrp ! Way better for reviewing :) On the architecture point, you wished to have fewer code. To further reach that, we could think of merging the functions...
That's great Matin! FYI Regarding the csv file, in pypsa-earth we added a filtering of the regions to adapt to that. A periodic check may be a good idea to...
> Thanks for your suggestion, @enricogiglio! AFAICS, both formulations would result in a MINLP. Since we didn't want to support MINLP problems, extendable generators were made not committable. I don't...
Revert and then applying back is an option to test. It is advisable to check the size of the whole repo in doing so, to make sure the repo does...
> Hey! You can also keep @siddharth-krishna in the loop. He is our git pro ;) > Reverting the merge commit can still be quite challenging in case other commits...