Dave Pagurek
Dave Pagurek
This approach looks like it should work! I haven't yet had the chance to run this myself, but it would help with review if you tried making a test sketch...
Hi @hxrshxz! It looks like that example isn't using noise in p5.strands, it's using it in beginShape/endShape. A test of p5.strands would use noise to offset vertex positions in a...
It looks like `saveFrames` sets two timers, one that runs `n` times to create the frames, and a second that downloads all of them. These two timers currently race each...
Thanks @wayneharish10! I'll assign this to you.
Sorry for the delay @HarishVX2! that sounds good to me.
@HarishVX2, are you still working on this?
It looks like we also need to update the line shader. In the fill shader, it checks that the x value of the color is at least 0 as a...
Looks like this test is failing now: https://github.com/processing/p5.js/blob/2606c21ef4924bd995053193c1c8b66f3e014d25/test/unit/webgl/p5.RendererGL.js#L1406-L1429 This test should probably be a visual test since it's hard to understand what's actually failing by looking at a big array...
I think we can 1.x as-is, since we're just doing bugfixes in 1.x at this point.
Also in 2.x, hooks are in JavaScript primarily instead of GLSL, so instead of string matching on the source code, we could probably do something where we keep a reference...