Dave Warnock
Dave Warnock
> Hey @dave42w 👋 > > Is it up for review?? Hi, Wondering if you are able to do that review or if there is more I need to do....
@sansyrox I haven't marked the 2 conversations as resolved as I figured you need to be happy with my responses first. Is that the right approach?
Hi @sansyrox I think this is ready, just need to confirm that you are happy with my responses.
Hi @sansyrox I wanted to check if you are happy for the conversations to be marked as resolved?
Hi, @sansyrox I think the test failures are CI timeouts, this has passed all the tests at some point since the last change. Can we merge?
Hi @sansyrox After the CI updates this is passing all tests. Can we merge it please. Thanks
> Yep, agreed. This will also likely be a breaking change. Hopefully, we can keep that to a minimum at least for the documented ways of using Robyn. I'll do...