Dave Warnock

> I'm not interested in stabilizing the current testing infrastructure. It hasn't had a proper design pass and was mostly just hacked together to make `#[sqlx::test]` work. I'd appreciate it...

> I'm taking this feature into account with the offline refactor, this will probably be the next thing I tackle. Obviously, life changes so this didn't happen yet. However, this...

Thanks Raphael, As a first step, I think the documentation needs to be updated to make it clear that transactions can only be used for multiple calls to query if...

> Hey @sansyrox! As the middlewares are added on runtime the evaluation of coroutine cannot be made at first hand. I know that we were discussing how endpoints could be...

Hi @sansyrox I just wanted to check if you would accept this PR if I complete the code (obviously in an acceptable way) Thanks Dave

I've decided that set_static_files_directory is better as it does not imply you can/should add multiple static directories. Also if the directory does not exist then throw an assertion is going...

> Alright, one question > > What is the concern with > > ``` > app.serve_directory( > route="/test_dir", > directory_path=os.path.join(current_file_path, "build"), > index_file="index.html", > ) > ``` > > Apart...

> > not showing clearly enough in documentation > > Yes, this is very bad, and we should fix this! I tried and npm told me that it hated me...

> > I tried and npm told me that it hated me and I should run away :-) > > I will do it then. Let me make an issue...

> Hey @dave42w 👋 > > I just want to show that every router needs to have an `add_route` method. It can have variable args though and the base class...