Dave Warnock

> Hey @dave42w 👋 > > I just want to show that every router needs to have an `add_route` method. It can have variable args though and the base class...

If the constructor for RouterRouteArg has exactly the same arguments as the Router.add_route currently does then code changes should be minimal. eg In Robyn.add_route we construct a RouterRouteArg before passing...

Hi @sansyrox This passes mypy. It's slightly odd to me that the ABC class needs to be used for the argument but the specific subclass can be used for the...

Hi @sansyrox, I've been looking at this add_route issue a bit more. I'm finding it confusing, trying to follow the logic. Are there two separate stores of routes (Robyn object...

Hi @sansyrox > And there is only one Router instance, which holds all the routes. Why would you want to change that? Well before suggesting changes it is critical that...

See this https://github.com/sparckles/Robyn/pull/889 and the links it contains.

I'm stuck. See https://github.com/sparckles/Robyn/issues/996#issuecomment-2451630716

> Hey @dave42w 👋 > > Is it up for review?? Hesitant yes. I only commit when it passes all the tests and works to a completed step. a) by...

Hi @sansyrox I've just added the support for URL parameters. All committed with tests. So from my previous comment today b) is done. Feedback on a) c) and d) appreciated....

Hi @sansyrox I've sorted out the pyproject.toml problem (a) :-)