Robyn icon indicating copy to clipboard operation
Robyn copied to clipboard

BaseRobyn file_path and other parameters

Open dave42w opened this issue 10 months ago • 2 comments

          we probably also don't need a file_path in the subrouters now, right?

Originally posted by @sansyrox in https://github.com/sparckles/Robyn/issues/1100#issuecomment-2571437544

Agreed.

It seems to me that the SubRouter should not hold any of the general configuration (config object, filepath etc). Instead it needs to know the BaseRobyn that it belongs to (to get the config etc from). So include_router should set a ParentBaseRobyn property in the SubRouter that is being included.

dave42w avatar Jan 10 '25 15:01 dave42w

Yep, agreed. This will also likely be a breaking change.

sansyrox avatar Jan 10 '25 17:01 sansyrox

Yep, agreed. This will also likely be a breaking change.

Hopefully, we can keep that to a minimum at least for the documented ways of using Robyn.

I'll do it in small careful steps as usual.

dave42w avatar Jan 11 '25 09:01 dave42w