Daniel W. Robert

Results 29 comments of Daniel W. Robert
trafficstars

@vivialice I have a few design questions for this task: - What should the hover state look like for the chips view? - Do we want that specific purple color...

@vivialice thank you, this is very helpful! > If we are unable to use theme styles, I'd use shades of grey for the hover interactions for all. I'll stick with...

> Ideally, yes. I can anticipate scenarios where the color for the chips could be something more vibrant to suit the store's styling, but isn't suitable for text. Perfect, thanks...

@vivialice I was looking at [the figma file](https://www.figma.com/file/6ZhHLQ7ucHUYgWHr3nusNB/%F0%9F%94%8E-Filter-Blocks-%26-Patterns?node-id=374%3A6641) for this item and I see you note the following, re the dark alternate chip background: > Not sure if we can...

> as this block changes the colors of the heading, chips and link as a whole we should hold off on shipping this until the color targets can be separated....

> Are we able to decouple the link as well, so the color setting only changes the chips? @vivialice yeah, shouldn't be a problem! I propose we handle that in...

Based on some clarifications from @vivialice, I am [moving this issue over to the Storefront repo](https://github.com/woocommerce/storefront/issues/2026). We essentially need to adjust the styling for this notification from within the theme...

Tested this out and everything seems to work fine. Checks are all passing now, after rebase, so I'll go ahead and merge.