Daniel W. Robert

Results 29 comments of Daniel W. Robert
trafficstars

@namiokuzono I can’t seem to reproduce it but I do see the issue present on the site linked. I tested on [an atomic site of mine](https://atomictests.wpcomstaging.com/) using both TT2 and...

Hi, @aristath 👋 Just dropping a quick note to let you know we haven't forgotten about this! We'll plan to have a deeper look at everything during the next cooldown...

> would it be a good occasion to migrated them to TypeScript while doing so? This seems it could be really beneficial for future-proofing them. What do you think? @sunyatasattva...

> I'd say we go ahead merging this PR and we refactor in the next one, just because the work is already done and we can already use it. But...

@vivialice I'm not able to replicate this - I'm seeing the expected behavior: https://user-images.githubusercontent.com/481776/191609774-4a1b9f33-5a14-4653-bb1d-25a2b1d1a05a.mp4 What version are you running? It looks like this update came in 8.4.0.

Closing this out as this is now working for you, per our convo. 🎉

@vivialice thanks for reviewing this and nice catch on the badge! I will adjust this to be sure that is included in the control.

> Make sure that “Product Query” and “Products on Sale” show up on the Gutenberg inserter The Gutenberg feature plugin needs to be enabled for the PQ block to show...

@Aljullu looks like the last activity on this PR was ~10 months ago. Is this still relevant? I'd be happy to review it, if so. Otherwise I'll go ahead and...