Daniel Compton

Results 358 comments of Daniel Compton
trafficstars

Thanks for reporting this, I'll take a look ASAP. Thanks!

The Clojure guidelines have moved to http://dev.clojure.org/display/community/Library+Coding+Standards

I've looked at this and have a few thoughts. Because kibit reads source with a clojure reader, it isn't able to 'see' some of the infractions of the style guide...

Hi @pbudzik, thanks for this. I'll look at it more closely when I'm back from break. In the meantime, can you add some tests for this suggestion? Thanks!

I'm a little conflicted on this, #83 already has raised that `into []` isn't always equivalent to `vec`, specifically in the case where you're using reducers. If you wanted to...

This is a [fundamental limitation](https://github.com/jonase/kibit#known-limitations) of kibit. I don't think there's a way to work around this but I'd be happy to hear ideas.

Gotcha. We can't cover the general case of all macros but it should be possible to exclude sugared Java interop.

@jonase it looks like Kibit can now run against Knockbox successfully.

This would be handy if it was combined with metadata on the rules. Then we could get the metadata from the rules (or the original functions), and only make suggestions...

I'm inclined to agree with @technomancy on this. I propose removing single-branch if -> when rules, but making them available through add-on custom rules #66. Thoughts?